Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RTD to use Python 3.12 and ubuntu-24.04 #1007

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Bump RTD to use Python 3.12 and ubuntu-24.04 #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4cb920
Bump RTD to use Python 3.12 and ubuntu-24.04
bdraco Sep 9, 2024
3d8502c
Update .github/workflows/ci-cd.yml
bdraco Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
version: 2

build:
os: ubuntu-22.04
os: ubuntu-24.04
tools:
python: >-
3.9
3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. In the past, I'd keep this at the lowest possible value to accommodate docs contributors running this on various versions. However, nowadays, I sometimes make it have the version that matches GHA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco this is something I'd like to have in the future: https://github.com/ansible/awx-plugins/blob/8ba56cc/.readthedocs.yaml — the same entry-points/automations being called @ RTD and GHA. That project doesn't use make, but I wanted to show the general idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does looks like a nicer / more maintainable design. I'm still wrapping my head around all the GHAs between all the projects. Its a lot to take in, and I'm playing catch up.


python:
install:
Expand Down
Loading