Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined CI fixes #996

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Combined CI fixes #996

merged 3 commits into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 9, 2024
@bdraco bdraco force-pushed the ci_fixes_single_pr branch from 71d6943 to 1780c55 Compare September 9, 2024 21:01
The builds no longer work for 3.7
@bdraco bdraco force-pushed the ci_fixes_single_pr branch from 1780c55 to 4fffc3d Compare September 9, 2024 21:02
@bdraco bdraco marked this pull request as ready for review September 9, 2024 21:04
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (bc86d23) to head (4fffc3d).
Report is 54 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   95.05%   94.97%   -0.09%     
==========================================
  Files          21       21              
  Lines        2407     2407              
  Branches      275      275              
==========================================
- Hits         2288     2286       -2     
- Misses         47       49       +2     
  Partials       72       72              
Flag Coverage Δ
CI-GHA 94.97% <ø> (-0.09%) ⬇️
MyPy 67.07% <ø> (+0.05%) ⬆️
unit 98.73% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 4fffc3d into master Sep 9, 2024
44 of 48 checks passed
@bdraco bdraco deleted the ci_fixes_single_pr branch September 9, 2024 21:25
@webknjaz
Copy link
Member

webknjaz commented Sep 9, 2024

Tip

@bdraco pro tip: if you merge multiple branches (that already have PRs) together (using regular/natural merge), and then make a PR out of that branch, merging it will mark all the dependent PRs as merged two, and you wouldn't need to close them all manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants