Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to AIP-127 in AIP-136 Custom methods for extra guidance on body definition. #1272

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add link to AIP-127 in AIP-136 Custom methods for extra guidance on body definition. #1272

merged 1 commit into from
Nov 17, 2023

Conversation

amanda-tarafa
Copy link
Contributor

No description provided.

@amanda-tarafa amanda-tarafa requested a review from a team as a code owner November 16, 2023 20:20
noahdietz
noahdietz approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amanda!

jskeet
jskeet reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of the "However, if using GET, the body clause must be absent" part deliberate?

@amanda-tarafa
Copy link
Contributor Author

Is the removal of the "However, if using GET, the body clause must be absent" part deliberate?

Yes, because that and more it's included on AIP-127, for instance, quoting:

  • RPCs must not define a body at all for RPCs that use the GET or DELETE HTTP verbs.
  • RPCs must use the prescribed body for Create (AIP-133) and Update (AIP-134) requests.

jskeet
jskeet approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. LGTM.

@noahdietz noahdietz merged commit c5f92af into aip-dev:master Nov 17, 2023
@amanda-tarafa amanda-tarafa deleted the custom-methods-body branch November 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@noahdietz noahdietz noahdietz approved these changes

@itsStrobe itsStrobe Awaiting requested review from itsStrobe itsStrobe is a code owner automatically assigned from aip-dev/google

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607 bgrant0607 is a code owner automatically assigned from aip-dev/google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanda-tarafa @jskeet @noahdietz