Squashed 'airdcpp-webapi/' changes from d8fdda516..bcde0a73a

bcde0a73a Include cleanup 946fae3d0 Don't install blocked extensions git-subtree-dir: airdcpp-webapi git-subtree-split: bcde0a73ad50d865dbc543bec9806207d7fdc5a6
airdcpp-web · Dec 5, 2020 · 2a10da8 · 2a10da8
1 parent a211cf8
commit 2a10da8
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 2 deletions.
diff --git a/api/TransferApi.cpp b/api/TransferApi.cpp
@@ -25,7 +25,6 @@
 #include <airdcpp/Download.h>
 #include <airdcpp/Upload.h>
 
-#include <airdcpp/AirUtil.h>
 #include <airdcpp/DownloadManager.h>
 #include <airdcpp/ConnectionManager.h>
 #include <airdcpp/QueueManager.h>

diff --git a/api/common/MessageUtils.cpp b/api/common/MessageUtils.cpp
@@ -25,7 +25,6 @@
 #include <web-server/Session.h>
 
 #include <airdcpp/ActionHook.h>
-#include <airdcpp/AirUtil.h>
 #include <airdcpp/Magnet.h>
 #include <airdcpp/MessageCache.h>
 #include <airdcpp/ShareManager.h>

diff --git a/web-server/ApiSettingItem.h b/web-server/ApiSettingItem.h
@@ -19,6 +19,8 @@
 #ifndef DCPLUSPLUS_DCPP_APISETTINGITEM_H
 #define DCPLUSPLUS_DCPP_APISETTINGITEM_H
 
+#include "stdinc.h"
+
 #include <airdcpp/GetSet.h>
 #include <airdcpp/SettingItem.h>
 #include <airdcpp/ResourceManager.h>

diff --git a/web-server/ExtensionManager.cpp b/web-server/ExtensionManager.cpp
@@ -462,6 +462,16 @@ namespace webserver {
 			return;
 		}
 
+		// Check blocked extensions
+		{
+			RLock l(cs);
+			auto i = blockedExtensions.find(extensionName);
+			if (i != blockedExtensions.end()) {
+				failInstallation(aInstallId, STRING(WEB_EXTENSION_INSTALL_BLOCKED), i->second);
+				return;
+			}
+		}
+
 		// Updating an existing extension?
 		auto extension = getExtension(extensionName);
 		if (extension) {

diff --git a/web-server/NpmRepository.cpp b/web-server/NpmRepository.cpp
@@ -26,6 +26,7 @@
 #include <airdcpp/ResourceManager.h>
 #include <airdcpp/ScopedFunctor.h>
 #include <airdcpp/Thread.h>
+#include <airdcpp/Util.h>
 
 
 namespace webserver {