Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid hiding stderr from dos2unix to make it easier to notice problems #8

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

vith
Copy link
Contributor

@vith vith commented Mar 15, 2018

Now the output will end like this when silly people like me forget to install dos2unix like at #5 (comment):

$ make
...snip...
cc -c -DCRC="$(cat 1600x1200.crc)" -o 1600x1200.p 1600x1200.S
objcopy -Oihex 1600x1200.p 1600x1200.bin.ihex
dos2unix --quiet 1600x1200.bin.ihex
make: dos2unix: Command not found
make: *** [Makefile:33: 1600x1200.bin.ihex] Error 127
rm 1920x1080x120.00.bin.nocrc 1600x1200.bin.nocrc 1920x1080x120.00.crc 1600x1200.crc 1600x1200.p 1920x1080x120.00.o 1600x1200.o 1920x1080x120.00.p

@akatrevorjay
Copy link
Owner

Nice!

@akatrevorjay
Copy link
Owner

I'm not sure why I removed stderr output here to be honest, must have been an oversight on my end?

@akatrevorjay akatrevorjay merged commit 31a6f80 into akatrevorjay:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants