Skip to content

Commit

Permalink
opt-in BUILDOUT_SKIP_PG_USER_CHECK anybox#63
Browse files Browse the repository at this point in the history 
This new env var enables to skip the postgres user check. This can be handy when linking to some default Postgres containers.
See anybox#63
  • Loading branch information
@rvalyi
rvalyi committed Oct 13, 2015
1 parent 449dc8c commit 4ed049f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion anybox/recipe/odoo/runtime/session.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ def open(self, db=None, with_demo=False):
cr.close()

startup.check_root_user()
startup.check_postgres_user()
if not os.environ.get('BUILDOUT_SKIP_PG_USER_CHECK'):
startup.check_postgres_user()
openerp.netsvc.init_logger()

saved_without_demo = config['without_demo']
Expand Down

4 comments on commit 4ed049f

@gracinet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I understand well, any non empty value of the environment variable, including "False" will have the check be skipped.

Maybe we should mention this in the documentation ? There's no goot place for such runtime behaviour, I think, so by default, I'd say at the end of http://docs.anybox.fr/anybox.recipe.odoo/current/scripts.html#startup-scripts so that at least a search on check_postgres would return something.

@rvalyi
Copy link
Member Author

@rvalyi rvalyi commented on 4ed049f Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll document that. You understood well. Also I propose to name the env var flag simply: ENABLE_POSTGRES_USER that would avoid a double negation.

I wondered if the var had to be prefixed by something special to show it belongs to this recipe. But a counter argument is that without prefix it could also be usable in Odoo one day. So I don't know. I propose ENABLE_POSTGRES_USER. Any better idea?

@gracinet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the naming

@gracinet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and thank you for the contribution, of course !

Please sign in to comment.