Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs, adjust README #4

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

pitrson
Copy link
Collaborator

@pitrson pitrson commented Sep 28, 2024

Addresses #2

README.md

  • adjusted to add examples on how to:
    • set unlimited amount of generated pages (new)
    • how to use '+tag' (code was there, but not mentioned in README

Pagelist

  • fixed bug in regex in re.finditer
    • fixes unwated behavior where e.g. {pagelist index1} would be matched as {pagelist i} - tags starting with either 'g' or 'i' would trigger this bug (tested via https://pythex.org/ )
  • if pagelist is called with first argument being 0 it would treat the limit as None. This is a workaround, because of the way the pagelist logic is written in - it always expects either 'i', 'g' or digit as a first arguments and behaves wrongly if it's not there. Workarounds scenarios where e.g. instead of {pagelist tag1} - not working , user should configure {pagelist 0 tag1} instead
  • adjusted logic for link generation to omit generating the link for the same page the plugin is supposed to generate links on as I don't see any use-case for this

@alanpt alanpt merged commit c7489a6 into alanpt:main Nov 22, 2024
Copy link
Owner

@alanpt alanpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants