Fixing type import #189
Open
Fixing type import #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import `EditOptions` directly from 'leaflet' results into a "Cannot use namespace EditOptions as a type" error.
robinmolen
added a commit
to open-formulieren/formio-builder
that referenced
this pull request
Jan 14, 2025
…t error The react-leaflet-draw throws an error when building the project. To supress this error, `"skipLibCheck": true` has been added to the tsconfig.json. I've made a PR to react-leaflet-draw to fix this issue (alex3165/react-leaflet-draw#189). When the typescript issue is resolved, the `"skipLibCheck": true` config should be removed from the tsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import
EditOptionsdirectly from 'leaflet' results into a "Cannot use namespace EditOptions as a type" error.To fix this i have changed the
EditOptionsimport withControl, and using theControl.EditOptionsto get the real type definition. In "@types/leaflet-draw"EditOptionsis defined asnamespacedescribing a completely different functionality.Seeing how this project is a extension/implementation of leaflet-draw as a React component, it only makes sense that the types definitions of leaflet-draw are added as dependency.