Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for multi-cluster replication #494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

arlyon
Copy link

@arlyon arlyon commented Sep 4, 2023

This adds the bare minimum changes to enable multi-cluster replication, and adds some docs to explain concretely how to achieve it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@alexandrevilain alexandrevilain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arlyon ! Thanks this is huge !!
I agree that this is the first step before a more complete replication handling by the operator. For now the documentation is sufficient.
I added some comments on the API side.

api/v1beta1/temporalcluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/temporalcluster_types.go Show resolved Hide resolved
api/v1beta1/temporalcluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/temporalcluster_types.go Show resolved Hide resolved
@arlyon
Copy link
Author

arlyon commented Dec 1, 2023

apologies for the delay, new version up now

@arlyon arlyon force-pushed the feat/cluster-replication branch from 4360579 to e1aea29 Compare December 1, 2023 14:44
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexandrevilain
Copy link
Owner

Hi @arlyon !
e2e are all failing :)

@arlyon arlyon force-pushed the feat/cluster-replication branch from e1aea29 to 78e163c Compare January 4, 2024 14:32
@arlyon
Copy link
Author

arlyon commented Jan 4, 2024

Hi, I am about to push another commit after rebasing. I can't run kind on my machine (rootless podman) so this might be a little tedious but it seems like a simple enough fix.

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Hades32
Copy link

Hades32 commented Feb 28, 2024

Hey folks, is this going to land soon?

Multi-cluster replication would be huge for migrating to this operator and afaik it's the only way to change shard-count without killing the cluster!

@arlyon arlyon force-pushed the feat/cluster-replication branch from 33ae24c to 6e8c21d Compare March 6, 2024 10:26
@arlyon
Copy link
Author

arlyon commented Mar 6, 2024

I fixed the lint error now. It is slow going as I can't run the tests locally since they rely on kind, each iteration requires CI approval, and, most importantly, I am slow to update this :)

Hopefully we can get it landed soon.

@arlyon arlyon force-pushed the feat/cluster-replication branch 2 times, most recently from 26f5f1a to a873d99 Compare March 12, 2024 17:47
@arlyon
Copy link
Author

arlyon commented Mar 12, 2024

Hey @alexandrevilain apologies for the back-and-forth. I got access to a machine that can run kind and have verified that the e2e tests work now.

@alexandrevilain
Copy link
Owner

Hey @alexandrevilain apologies for the back-and-forth. I got access to a machine that can run kind and have verified that the e2e tests work now.

Greeeat! I’ll review this as soon as possible! Thanks for your work! 👌

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@alexandrevilain alexandrevilain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only wording comments! We're close to the merge !
Thanks again for your awesome work!

api/v1beta1/temporalcluster_types.go Outdated Show resolved Hide resolved
docs/features/multi-cluster-replication.md Outdated Show resolved Hide resolved
docs/features/multi-cluster-replication.md Outdated Show resolved Hide resolved
@alexandrevilain
Copy link
Owner

Hi @arlyon !

Do you need so help for the last few steps ? :)

@arlyon arlyon force-pushed the feat/cluster-replication branch from 73a7af8 to 4892e87 Compare July 25, 2024 10:06
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@arlyon arlyon requested a review from alexandrevilain July 25, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants