-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic support for multi-cluster replication #494
base: main
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arlyon ! Thanks this is huge !!
I agree that this is the first step before a more complete replication handling by the operator. For now the documentation is sufficient.
I added some comments on the API side.
apologies for the delay, new version up now |
4360579
to
e1aea29
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @arlyon ! |
e1aea29
to
78e163c
Compare
Hi, I am about to push another commit after rebasing. I can't run kind on my machine (rootless podman) so this might be a little tedious but it seems like a simple enough fix. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Hey folks, is this going to land soon? Multi-cluster replication would be huge for migrating to this operator and afaik it's the only way to change shard-count without killing the cluster! |
33ae24c
to
6e8c21d
Compare
I fixed the lint error now. It is slow going as I can't run the tests locally since they rely on Hopefully we can get it landed soon. |
26f5f1a
to
a873d99
Compare
Hey @alexandrevilain apologies for the back-and-forth. I got access to a machine that can run |
Greeeat! I’ll review this as soon as possible! Thanks for your work! 👌 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only wording comments! We're close to the merge !
Thanks again for your awesome work!
Hi @arlyon ! Do you need so help for the last few steps ? :) |
73a7af8
to
4892e87
Compare
Quality Gate failedFailed conditions |
This adds the bare minimum changes to enable multi-cluster replication, and adds some docs to explain concretely how to achieve it.