Add payment index to payviapaymentrequest and subscribetopayviarequest #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed, comments, typescript and test cases. |
alexbosworth
reviewed
Sep 5, 2024
alexbosworth
reviewed
Sep 5, 2024
alexbosworth
reviewed
Sep 5, 2024
|
I added a comment on the attribute doc description, generally in those i try to kind of restate the field but in a different way than the actual naming So I think this should be lining up with the offset number you'd see in the list of total payments |
Co-authored-by: Alex Bosworth <[email protected]>
Co-authored-by: Alex Bosworth <[email protected]>
Co-authored-by: Alex Bosworth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.