- Optimized M160 check

alexdelprete · Jan 16, 2025 · d922440 · d922440
1 parent 47e690c
commit d922440
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/custom_components/abb_powerone_pvi_sunspec/api.py b/custom_components/abb_powerone_pvi_sunspec/api.py
@@ -18,6 +18,7 @@
     DEVICE_STATUS,
     INVERTER_TYPE,
     SUNSPEC_M160_OFFSETS,
+    SUNSPEC_MODEL_160_ID,
 )
 
 _LOGGER = logging.getLogger(__name__)
@@ -254,8 +255,7 @@ def find_sunspec_modbus_m160_offset(self) -> int:
             invmodel = self.data["comm_model"].upper()
             found_offset = 0
             multi_mppt_id = 0
-            offsets = SUNSPEC_M160_OFFSETS
-            for offset in offsets:
+            for offset in SUNSPEC_M160_OFFSETS:
                 _LOGGER.debug(
                     f"(find_m160) Find M160 for model: {invmodel} at offset: {offset}"
                 )
@@ -266,7 +266,7 @@ def find_sunspec_modbus_m160_offset(self) -> int:
                     read_model_160_data.registers, byteorder=Endian.BIG
                 )
                 multi_mppt_id = decoder.decode_16bit_uint()
-                if multi_mppt_id != 160:
+                if multi_mppt_id != SUNSPEC_MODEL_160_ID:
                     _LOGGER.debug(
                         f"(find_m160) Model is not 160 - offset: {offset} - multi_mppt_id: {multi_mppt_id}"
                     )

diff --git a/custom_components/abb_powerone_pvi_sunspec/const.py b/custom_components/abb_powerone_pvi_sunspec/const.py
@@ -40,6 +40,7 @@
 DEFAULT_SCAN_INTERVAL = 60
 MIN_SCAN_INTERVAL = 30
 SUNSPEC_M160_OFFSETS = [122, 1104, 208]
+SUNSPEC_MODEL_160_ID = 160
 STARTUP_MESSAGE = f"""
 -------------------------------------------------------------------
 {NAME}