Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename mask into sparsity_mask #60

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Rename mask into sparsity_mask #60

merged 5 commits into from
Jul 10, 2024

Conversation

pbarbarant
Copy link
Collaborator

Closes #56

@bthirion
Copy link
Collaborator

bthirion commented Jul 9, 2024

LGTM, but can you check the non executed or failing tests ?

@pbarbarant
Copy link
Collaborator Author

LGTM, but can you check the non executed or failing tests ?

This is related to #62 which will be resolved after merging #63 .

@pbarbarant pbarbarant merged commit 1cfdaff into alexisthual:main Jul 10, 2024
7 checks passed
@pbarbarant pbarbarant deleted the fix/56-rename-sparsity-mask branch July 10, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename sparsity_mask so that it's not confused with a nilearn masker.
2 participants
@pbarbarant @bthirion