-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with laravel/scout
v10.11.6
#347
Comments
Can confirm this issue too |
Same, can confirm this issue too |
+1 on this issue, running same versions including v3.x of Algolia client |
Came to report the same. 😅 |
Today I've just had the same issue with my Laravel application, the way I ended up solving the issue is by hardcoding the version of
|
@Eyad-Bereh same here |
Yes, same here, please fix it. |
I don't know what I'm missing here exactly, but converting an instantiatable class into an abstract class seems like a breaking change to me, and so it should've been done in a major release and not break the entire thing by releasing this breaking change in a minor version |
As suggested by Eyad-Bereh a quick fix is to downgrade Laravel Scout to v10.11.5.
I've submitted PR #348 to do just that. |
PR #348 is a useful workaround, but it doesn't fix this problem, so should the issue be closed ? |
It's definitely not a long-term solution, it's just a workaround until a permanent solution is implemented, but the current situation is somewhat severe and people are having their applications breaking down over this issue. |
The issue is not fixed long-term indeed, the PR was a temporary fix for now. Github automatically closed the issue when merging the PR I suppose, so I'm reopening it for now! |
So the issue is that Addendum |
Description
The latest version of Laravel Scout
v10.11.6
has the following error:Class Algolia\ScoutExtended\Engines\AlgoliaEngine contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Laravel\Scout\Engines\AlgoliaEngine::performSearch, Laravel\Scout\Engines\AlgoliaEngine::deleteIndex)
A possible fix for this issue is to use the new class called
Algolia3Engine
which was created in laravel/scout#872 instead of theAlgoliaEngine
which is now an abstract class.Steps To Reproduce
Update to latest version of Laravel Scout.
The text was updated successfully, but these errors were encountered: