Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict with Laravel/Scout v10.11.6 and newer #348

Conversation

mariuscucuruz
Copy link
Contributor

@mariuscucuruz mariuscucuruz commented Nov 18, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #347, #883, #855
Need Doc update no

Describe your change

Downgraded laravel/scout to version v10.11.5 in composer.json to resolve a conflict with the Algolia Search Client.

Details

This change addresses compatibility issues between Laravel Scout v10.11.6 (and newer) and recent versions Algolia Search Client, ensuring stable integration.

The proposed solution is to downgrade downgrade dependency Laravel Scout to v10.11.5.

Related Issues

Context

Laravel Scout v10.11.6 and v10.11.7 have conflicts with all recent versions of Algolia Search Client.

    "conflict": {
        "algolia/algoliasearch-client-php": "<3.2.0|>=5.0.0"
    },

@mariuscucuruz mariuscucuruz changed the title fix conflict with Laravel Scout v10.11.6+ Fix conflict with Laravel/Scout v10.11.6 and newer Nov 18, 2024
@DevinCodes DevinCodes self-requested a review November 21, 2024 10:50
Copy link
Contributor

@DevinCodes DevinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mariuscucuruz ,

Thank you for the PR. A small change is needed in the version constraint it seems, as the CI is still pulling in the version we're incompatible with (since that matches ^10.0).

In order for the CI to pass, you'll also need to remove line 10 in the phpstan.neon.dist file, which seems odd since that line was needed before to have the CI pass. You can do this manually, or cherry-pick commit f319b64 onto your branch, whichever works best for you 🙂

Thank you in advance, I'll merge & deploy this once the changes have been applied and the CI passes!

composer.json Outdated Show resolved Hide resolved
Marius Cucuruz added 2 commits November 21, 2024 17:08
• Corrected a faulty version constraint in `composer.json`.
• Allowed for compatibility with Laravel Scout versions 9.0, 10.0, and up to 10.11.5.
@mariuscucuruz
Copy link
Contributor Author

Thank you for the PR. A small change is needed in the version constraint it seems, as the CI is still pulling in the version we're incompatible with (since that matches ^10.0).

In order for the CI to pass, you'll also need to remove line 10 in the phpstan.neon.dist file, which seems odd since that line was needed before to have the CI pass. You can do this manually, or cherry-pick commit f319b64 onto your branch, whichever works best for you 🙂

Hey @DevinCodes,

I've updated composer to "laravel/scout": "^9.0||^10.0 <10.11.6", to prevent limit Scout to v10.11.5.
I've also removed the line as per commit f319b644.

However the CI is still failing for some reason. What would you suggest to fix this?

Cheers.

@DevinCodes
Copy link
Contributor

Thank you for the updates @mariuscucuruz ! The CI was failing due to permission setup, I just triggered it again and the tests are passing!

I'll merge and release this later today!

@DevinCodes DevinCodes merged commit 052f7dd into algolia:master Nov 22, 2024
6 checks passed
@DevinCodes
Copy link
Contributor

This has been released in v3.1.1. Thank you again for the contribution!

@mariuscucuruz mariuscucuruz deleted the hotfix/fix-laravel-scout-compatibity-issue branch December 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with laravel/scout v10.11.6
2 participants