-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflict with Laravel/Scout v10.11.6 and newer #348
Fix conflict with Laravel/Scout v10.11.6 and newer #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mariuscucuruz ,
Thank you for the PR. A small change is needed in the version constraint it seems, as the CI is still pulling in the version we're incompatible with (since that matches ^10.0
).
In order for the CI to pass, you'll also need to remove line 10 in the phpstan.neon.dist
file, which seems odd since that line was needed before to have the CI pass. You can do this manually, or cherry-pick commit f319b64 onto your branch, whichever works best for you 🙂
Thank you in advance, I'll merge & deploy this once the changes have been applied and the CI passes!
• Corrected a faulty version constraint in `composer.json`. • Allowed for compatibility with Laravel Scout versions 9.0, 10.0, and up to 10.11.5.
Hey @DevinCodes, I've updated composer to However the CI is still failing for some reason. What would you suggest to fix this? Cheers. |
Thank you for the updates @mariuscucuruz ! The CI was failing due to permission setup, I just triggered it again and the tests are passing! I'll merge and release this later today! |
This has been released in v3.1.1. Thank you again for the contribution! |
Describe your change
Downgraded
laravel/scout
to version v10.11.5 in composer.json to resolve a conflict with the Algolia Search Client.Details
This change addresses compatibility issues between Laravel Scout v10.11.6 (and newer) and recent versions Algolia Search Client, ensuring stable integration.
The proposed solution is to downgrade downgrade dependency Laravel Scout to v10.11.5.
Related Issues
laravel/scout
v10.11.6 #347performSearch
anddeleteIndex
are not implemented #883Context
Laravel Scout v10.11.6 and v10.11.7 have conflicts with all recent versions of Algolia Search Client.