Merge branch 'release/2.4.0'

algorand · Oct 25, 2023 · a80b519 · a80b519
2 parents 1c853b6 + af7c719
commit a80b519
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,16 @@
+# 2.4.0
+
+<!-- Release notes generated using configuration in .github/release.yml at release/2.4.0 -->
+
+## What's Changed
+### Enhancements
+* Patch: Remove de-duping via HashSet from accounts,foriegn apps, and foreign … by @gmalouf in https://github.com/algorand/java-algorand-sdk/pull/652
+
+## New Contributors
+* @gmalouf made their first contribution in https://github.com/algorand/java-algorand-sdk/pull/652
+
+**Full Changelog**: https://github.com/algorand/java-algorand-sdk/compare/2.3.0...2.4.0
+
 # 2.3.0
 
 <!-- Release notes generated using configuration in .github/release.yml at release/2.3.0 -->

diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ Maven:
 <dependency>
     <groupId>com.algorand</groupId>
     <artifactId>algosdk</artifactId>
-    <version>2.3.0</version>
+    <version>2.4.0</version>
 </dependency>
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
 
     <groupId>com.algorand</groupId>
     <artifactId>algosdk</artifactId>
-    <version>2.3.0</version>
+    <version>2.4.0</version>
     <packaging>jar</packaging>
 
     <name>${project.groupId}:${project.artifactId}</name>

diff --git a/src/main/java/com/algorand/algosdk/builder/transaction/MethodCallTransactionBuilder.java b/src/main/java/com/algorand/algosdk/builder/transaction/MethodCallTransactionBuilder.java
@@ -12,7 +12,6 @@
 
 import java.math.BigInteger;
 import java.util.ArrayList;
-import java.util.HashSet;
 import java.util.List;
 
 @SuppressWarnings("unchecked")
@@ -105,7 +104,7 @@ public T signer(TxnSigner signer) {
     @Override
     public T accounts(List<Address> accounts) {
         if (accounts != null)
-            this.foreignAccounts = new ArrayList<>(new HashSet<>(accounts));
+            this.foreignAccounts = new ArrayList<>(accounts);
         else
             this.foreignAccounts.clear();
         return (T) this;
@@ -114,7 +113,7 @@ public T accounts(List<Address> accounts) {
     @Override
     public T foreignApps(List<Long> foreignApps) {
         if (foreignApps != null)
-            this.foreignApps = new ArrayList<>(new HashSet<>(foreignApps));
+            this.foreignApps = new ArrayList<>(foreignApps);
         else
             this.foreignApps.clear();
         return (T) this;
@@ -123,7 +122,7 @@ public T foreignApps(List<Long> foreignApps) {
     @Override
     public T foreignAssets(List<Long> foreignAssets) {
         if (foreignAssets != null)
-            this.foreignAssets = new ArrayList<>(new HashSet<>(foreignAssets));
+            this.foreignAssets = new ArrayList<>(foreignAssets);
         else
             this.foreignAssets.clear();
         return (T) this;