Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: participation key error handling #58

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

PhearZero
Copy link
Member

ℹ Overview

  • adds missing error handler for modals to display messages from in-app errors
  • fixes error passed as pointer

@PhearZero PhearZero added the bug Something isn't working label Jan 6, 2025
@PhearZero PhearZero added this to the Milestone 2 milestone Jan 6, 2025
@PhearZero PhearZero self-assigned this Jan 6, 2025
@tasosbit tasosbit merged commit ec8d8bc into main Jan 7, 2025
1 check passed
@tasosbit tasosbit deleted the fix/error-display-on-generate branch January 7, 2025 11:06
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.69%. Comparing base (1d4b596) to head (19bb7e2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ui/modal/controller.go 0.00% 5 Missing and 1 partial ⚠️
internal/algod/participation/participation.go 0.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (1d4b596) and HEAD (19bb7e2). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1d4b596) HEAD (19bb7e2)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
- Coverage   49.04%   36.69%   -12.35%     
===========================================
  Files          74       74               
  Lines        5705     5714        +9     
===========================================
- Hits         2798     2097      -701     
- Misses       2702     3519      +817     
+ Partials      205       98      -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tasosbit added a commit that referenced this pull request Jan 22, 2025
…enerate

fix: participation key error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants