Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Add Dockerfiles for Rocky 9 and handle Qt 6 installation #2626

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Dec 23, 2024

Description

This PR updates the Dockerfiles for Meshroom as follows:

  • The Dockerfiles for CentOS 7 are replaced with Dockerfiles for Rocky 9
  • The version of Ubuntu and CUDA is upgraded for the Ubuntu Dockerfiles (from 20.04 to 22.04)
  • The installation of Qt is updated to correctly use the installer for Qt 6

Features list

  • Remove CentOS 7 Dockerfiles and scripts
  • Update Ubuntu Dockerfiles
  • Add new Dockerfiles and scripts for Rocky 9

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (0aa163d) to head (2aabc06).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2626   +/-   ##
========================================
  Coverage    69.89%   69.90%           
========================================
  Files          121      121           
  Lines         7076     7078    +2     
========================================
+ Hits          4946     4948    +2     
  Misses        2130     2130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbentejac cbentejac marked this pull request as ready for review January 20, 2025 13:47
@sebastienmascha
Copy link

Thank you for this great PR.

I am new to Meshroom, I would like to know more about the Docker infrastructure design and eventually contribute to the project as well.

For AliceVision and Meshroom, why are we using a dl folder and use wget --no-check-certificate "https://download.qt.io/official_releases/online_installers/qt-unified-linux-x64-online.run in the build-*.sh scripts?

Why not directly include those calls in the Dockerfile? It would improve the isolation and avoid unnecessary Build Context.

I am happy to create a PR if needed.

@sebastienmascha
Copy link

sebastienmascha commented Jan 22, 2025

Why not add the environment variables inside the docker as well?

export ALICEVISION_ROOT=/opt/AliceVision_install
export ALICEVISION_SENSOR_DB=/opt/AliceVision_install/share/aliceVision/cameraSensors.db
export ALICEVISION_VOCTREE=/opt/AliceVision_install/share/aliceVision/vlfeat_K80L3.SIFT.tree
export ALICEVISION_SPHERE_DETECTION_MODEL=/opt/AliceVision_install/share/aliceVision/sphereDetection_Mask-RCNN.onnx
export ALICEVISION_SEMANTIC_SEGMENTATION_MODEL=/opt/AliceVision_install/share/aliceVision/fcn_resnet50.onnx
export PATH=$PATH:/opt/AliceVision_install/bin
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/AliceVision_install/lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants