Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract more metadata using exifTool #2645

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

demoulinv
Copy link
Contributor

Description

This PR adds a pure python node dedicated to extract metadata from image files using exifTool. This node can be connected to the cameraInit node and for all images referenced in the "cameraInit.sfm" file, if exifTool is available, a file containing all metadata is generated. The file format can be selected amongst "txt", "xmp", "xml". Be aware that the "xmp" format cannot store all metadata contained in the image file.

Features list

Implementation remarks

The invocated exifTool command depends on the requested file format in the following way:

  • "txt": exiftool [args] imageFile > metadataFile.txt
  • "xml": exiftool -X [args] imageFile > metadataFile.xml
  • "xmp": exiftool -tagsfromfile imageFile [args] metadataFile.xmp

Optional arguments 'args' can be defined through a string parameter of the meshroom node.
The boolean parameter "keepfilename" allows to keep the image file name for the metadata file but changing the file extension.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 55 lines in your changes missing coverage. Please review.

Project coverage is 69.44%. Comparing base (3e8b736) to head (baa2e22).
Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
meshroom/nodes/aliceVision/ExtractMetadata.py 8.33% 55 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2645      +/-   ##
===========================================
- Coverage    69.93%   69.44%   -0.50%     
===========================================
  Files          121      122       +1     
  Lines         7088     7144      +56     
===========================================
+ Hits          4957     4961       +4     
- Misses        2131     2183      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@servantftechnicolor servantftechnicolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I got non explicit errors if nothing is connected to the node
  • Nothing appears in the log if exiftool is not found
  • On Error, the node does not fail.

meshroom/nodes/aliceVision/ExtractMetadata.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants