Node: Propagate attribute change via valueChanged signal
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate attribute value changes downstream using `valueChanged` signal emission, instead of calling `_onAttributeChanged` directly. This does not change the current core behavior, but it triggers the property notification signal when in UI mode. This makes changes happening upstream properly reflected in downstream nodes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2657 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve propagation of attribute value change signals to get proper UI update.
Before
After
Alternative node debug display to better visualize what problem is being solved:
Features list
Implementation remarks
Propagate attribute value changes downstream using
valueChangedsignal emission, instead of calling_onAttributeChangeddirectly.This does not change the current core behavior, but it triggers the property notification signal when in UI mode.
This makes changes happening upstream properly reflected in downstream nodes.