Add useragent for OIDC assume role #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #929 +/- ##
=========================================
Coverage 90.16% 90.16%
Complexity 1649 1649
=========================================
Files 123 123
Lines 4736 4737 +1
Branches 536 536
=========================================
+ Hits 4270 4271 +1
Misses 342 342
Partials 124 124 ☔ View full report in Codecov by Sentry. |
JacksonTian
force-pushed
the
oidc
branch
2 times, most recently
from
d047a7a to
6afb189
Compare
yndu13
approved these changes
Jul 24, 2024
| @@ -147,6 +148,7 @@ private String invokeAssumeRoleWithOIDC() throws ClientException { | |||
| httpRequest.setHttpContentType(FormatType.FORM); | |||
| httpRequest.setSysConnectTimeout(1000); | |||
| httpRequest.setSysReadTimeout(3000); | |||
| httpRequest.putHeaderParameter("UserAgent", UserAgentConfig.resolve(null, null)); | |||
There was a problem hiding this comment.
这里要不要加上credentials的标识，以免和 API request 混合
There was a problem hiding this comment.
这个 API 本身只能用来 OIDC 角色扮演，不影响其它 API request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.