Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: limit jacoco agent to test scope #930

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Silic0nS0ldier
Copy link
Contributor

Test dependency org.jacoco:org.jacoco.agent is currently considered a compile dependency.

This PR limits it to the test scope.

@Silic0nS0ldier Silic0nS0ldier requested a review from xiahuai as a code owner July 25, 2024 01:37
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (57babea) to head (a6afd42).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #930      +/-   ##
============================================
- Coverage     90.16%   90.07%   -0.09%     
+ Complexity     1649     1648       -1     
============================================
  Files           123      123              
  Lines          4736     4736              
  Branches        536      536              
============================================
- Hits           4270     4266       -4     
- Misses          342      345       +3     
- Partials        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian
Copy link
Contributor

LGTM. Thanks for your contribution.

@JacksonTian JacksonTian merged commit 39e7a07 into aliyun:master Jul 25, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants