Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUM-4667 make AgmAgmAssociation live under the general AgmAssociati… #1816

Merged
merged 14 commits into from
Feb 7, 2025

Conversation

cmpich
Copy link
Contributor

@cmpich cmpich commented Jan 22, 2025

…on load job

Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have migration to change the column name in the database and indexes

Copy link
Member

@markquintontulloch markquintontulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need a migration to delete the "AGM AGM Association" load group and loads created in the previous PR

@cmpich cmpich requested a review from oblodgett January 30, 2025 21:18
Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Alpha Database.

Table agmagmassociation contains the following:

Database state

  • Columns:
    • agmassociationsubject_id
    • agmassociationobject_id
  • Indexes:
    • agmagmassociation_agmassocsubject_in
    • agmagmassociation_agmassocobject_in
  • FK's:
    • agmstrassociation_agmassocsubject_fk
    • agmstrassociation_agmassociationobject_fk

After running v0.38.0.29__agm_agm_association_loads_2.sql

Database state:

  • Columns:
    • agmassociationsubject_id
    • agmagmassociationobject_id
  • Indexes:
    • agmagmassociation_agmassocsubject_in
  • FK's:
    • agmstrassociation_agmassocsubject_fk

After running v0.38.0.30__agm_agm_association_loads_2.sql

Database state:

  • Columns:
    • agmassociationsubject_id
    • agmagmassociationobject_id
  • Indexes:
    • agmagmassociation_agmassocsubject_in
    • agmagmassociation_agmassocobject_in
  • FK's:
    • agmstrassociation_agmassocsubject_fk
    • agmagmassociation_agmassociationobject_fk

After running v0.38.0.31__agm_agm_association_loads_3.sql

Database state:

  • Columns:
    • agmassociationsubject_id
    • agmagmassociationobject_id
  • Indexes:
    • agmagmassociation_agmassociationsubject_index
    • agmagmassociation_agmagmassocicationobject_index
  • FK's:
    • agmstrassociation_agmassocsubject_fk
    • agmagmassociation_agmassociationsubject_id_fk
    • agmagmassociation_agmassociationobject_fk
    • agmagmassociation_agmagmassociationobject_id_fk

Notice in Java the index name is:
AgmAgmAssociation_AgmAgmAssociationObject_index
However in the database the index name is:
agmagmassociation_agmagmassocicationobject_index

I would suggest downloading the alpha dump and adjusting this migration accordingly.

Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just had a new migration come in so you will need to rename / renumber your migration files.

Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... the migrations will need to be renumbered.

@cmpich cmpich merged commit 9c936fd into alpha Feb 7, 2025
10 checks passed
@cmpich cmpich deleted the SCRUM-4667 branch February 7, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants