-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCRUM-4667 make AgmAgmAssociation live under the general AgmAssociati… #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have migration to change the column name in the database and indexes
src/main/java/org/alliancegenome/curation_api/model/entities/AffectedGenomicModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need a migration to delete the "AGM AGM Association" load group and loads created in the previous PR
src/main/java/org/alliancegenome/curation_api/model/entities/AffectedGenomicModel.java
Outdated
Show resolved
Hide resolved
src/test/java/org/alliancegenome/curation_api/AgmAgmAssociationBulkUploadITCase.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/v0.38.0.29__agm_agm_association_loads_2.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/v0.38.0.29__agm_agm_association_loads_2.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/v0.38.0.30__agm_agm_association_loads_2.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Alpha Database.
Table agmagmassociation
contains the following:
Database state
- Columns:
- agmassociationsubject_id
- agmassociationobject_id
- Indexes:
- agmagmassociation_agmassocsubject_in
- agmagmassociation_agmassocobject_in
- FK's:
- agmstrassociation_agmassocsubject_fk
- agmstrassociation_agmassociationobject_fk
After running v0.38.0.29__agm_agm_association_loads_2.sql
Database state:
- Columns:
- agmassociationsubject_id
- agmagmassociationobject_id
- Indexes:
- agmagmassociation_agmassocsubject_in
- FK's:
- agmstrassociation_agmassocsubject_fk
After running v0.38.0.30__agm_agm_association_loads_2.sql
Database state:
- Columns:
- agmassociationsubject_id
- agmagmassociationobject_id
- Indexes:
- agmagmassociation_agmassocsubject_in
- agmagmassociation_agmassocobject_in
- FK's:
- agmstrassociation_agmassocsubject_fk
- agmagmassociation_agmassociationobject_fk
After running v0.38.0.31__agm_agm_association_loads_3.sql
Database state:
- Columns:
- agmassociationsubject_id
- agmagmassociationobject_id
- Indexes:
- agmagmassociation_agmassociationsubject_index
- agmagmassociation_agmagmassocicationobject_index
- FK's:
- agmstrassociation_agmassocsubject_fk
- agmagmassociation_agmassociationsubject_id_fk
- agmagmassociation_agmassociationobject_fk
- agmagmassociation_agmagmassociationobject_id_fk
Notice in Java the index name is:
AgmAgmAssociation_AgmAgmAssociationObject_index
However in the database the index name is:
agmagmassociation_agmagmassocicationobject_index
I would suggest downloading the alpha dump and adjusting this migration accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just had a new migration come in so you will need to rename / renumber your migration files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... the migrations will need to be renumbered.
…on load job