Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ts.ValueExpression conversion #46

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

TomerAberbach
Copy link
Contributor

This handles two new cases:

  1. Strings that have characters that need to be escaped
  2. BigInts

Copy link
Contributor

github-actions bot commented Dec 22, 2024

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

  • @alloy-js/typescript
Show changes

@TomerAberbach
Copy link
Contributor Author

I think some of the CI stuff is not related to my change, but I went ahead and at least fixed the formatting thing

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

@alloy-js/babel-plugin

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/babel-plugin@46

@alloy-js/babel-plugin-jsx-dom-expressions

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/babel-plugin-jsx-dom-expressions@46

@alloy-js/core

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/core@46

@alloy-js/babel-preset

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/babel-preset@46

@alloy-js/csharp

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/csharp@46

@alloy-js/java

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/java@46

@alloy-js/prettier-plugin-alloy

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/prettier-plugin-alloy@46

@alloy-js/typescript

npm i https://pkg.pr.new/alloy-framework/alloy/@alloy-js/typescript@46

commit: 5566704

@bterlson bterlson merged commit 83cc365 into alloy-framework:main Jan 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants