Issue #764 - Added custom string-to-enum converter for the `AccountAc…

…tivityType` enum with fallback value.
alpacahq · Nov 10, 2024 · da5e307 · da5e307
1 parent f6bde3f
commit da5e307
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/Alpaca.Markets/Enums/AccountActivityType.cs b/Alpaca.Markets/Enums/AccountActivityType.cs
@@ -3,7 +3,7 @@
 /// <summary>
 /// Types of account activities
 /// </summary>
-[JsonConverter(typeof(StringEnumConverter))]
+[JsonConverter(typeof(AccountActivityTypeEnumConverter))]
 [SuppressMessage("ReSharper", "CommentTypo")]
 [SuppressMessage("ReSharper", "IdentifierTypo")]
 [SuppressMessage("ReSharper", "StringLiteralTypo")]
@@ -271,5 +271,12 @@ public enum AccountActivityType
     /// </summary>
     [UsedImplicitly]
     [EnumMember(Value = "CFEE")]
-    CryptoFee
+    CryptoFee,
+
+    /// <summary>
+    /// Unknown account activity type (i.e. one not supported by this version of SDK).
+    /// </summary>
+    [UsedImplicitly]
+    [EnumMember(Value = "UNKNOWN")]
+    Unknown
 }
diff --git a/Alpaca.Markets/Helpers/AccountActivityTypeEnumConverter.cs b/Alpaca.Markets/Helpers/AccountActivityTypeEnumConverter.cs
@@ -0,0 +1,14 @@
+namespace Alpaca.Markets;
+
+[SuppressMessage(
+    "Microsoft.Performance", "CA1812:Avoid uninstantiated internal classes",
+    Justification = "Object instances of this class will be created by Newtonsoft.JSON library.")]
+internal sealed class AccountActivityTypeEnumConverter : StringEnumConverter
+{
+    public override Object ReadJson(
+        JsonReader reader,
+        Type objectType,
+        Object? existingValue,
+        JsonSerializer serializer) =>
+        reader.ReadEnumString(AccountActivityType.Unknown);
+}
diff --git a/Alpaca.Markets/PublicAPI.Shipped.txt b/Alpaca.Markets/PublicAPI.Shipped.txt
@@ -54,6 +54,7 @@ Alpaca.Markets.AccountActivityType.StockSpinoff = 28 -> Alpaca.Markets.AccountAc
 Alpaca.Markets.AccountActivityType.StockSplit = 29 -> Alpaca.Markets.AccountActivityType
 Alpaca.Markets.AccountActivityType.SymbolChange = 27 -> Alpaca.Markets.AccountActivityType
 Alpaca.Markets.AccountActivityType.Transaction = 1 -> Alpaca.Markets.AccountActivityType
+Alpaca.Markets.AccountActivityType.Unknown = 37 -> Alpaca.Markets.AccountActivityType
 Alpaca.Markets.AccountStatus
 Alpaca.Markets.AccountStatus.AccountClosed = 13 -> Alpaca.Markets.AccountStatus
 Alpaca.Markets.AccountStatus.AccountUpdated = 3 -> Alpaca.Markets.AccountStatus