Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenClose.cs - make constructor public #735

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

michaelnero
Copy link
Contributor

@michaelnero michaelnero commented Mar 12, 2024

Description

make the openclose struct constructor public so we can construct instances of these to aid in testing.

Fixes # (issue)

OpenClose.cs

Type of change

made an internal constructor public

How Has This Been Tested?

ran unit tests for project

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@michaelnero michaelnero marked this pull request as ready for review March 12, 2024 08:25
@OlegRa OlegRa self-requested a review March 12, 2024 10:23
@OlegRa OlegRa self-assigned this Mar 12, 2024
@OlegRa OlegRa added the enhancement New feature or request label Mar 12, 2024
@OlegRa OlegRa added this to the SDK 7.x LTS milestone Mar 12, 2024
Copy link
Collaborator

@OlegRa OlegRa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run a local build and fix code analyzer issues related to API surface changes.

Alpaca.Markets/Helpers/OpenClose.cs Outdated Show resolved Hide resolved
@michaelnero michaelnero requested a review from OlegRa March 12, 2024 10:43
@OlegRa OlegRa merged commit fdcb2f4 into alpacahq:develop Mar 12, 2024
3 checks passed
@OlegRa
Copy link
Collaborator

OlegRa commented Mar 12, 2024

@michaelnero I'll re-integrate this change into 7.0.x branch and make a public release later today.

OlegRa pushed a commit that referenced this pull request Mar 12, 2024
* Update OpenClose.cs - make constructor public

* added inits instead of public ctor, fixed public API

(cherry picked from commit fdcb2f4)
OlegRa pushed a commit that referenced this pull request Mar 12, 2024
* Update OpenClose.cs - make constructor public

* added inits instead of public ctor, fixed public API

(cherry picked from commit fdcb2f4)
@OlegRa
Copy link
Collaborator

OlegRa commented Mar 12, 2024

@michaelnero You can test changes in version 7.0.3 available on NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants