Unify compiler name and version filter #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- print a row in a short and nice way
SimeonEhrig
force-pushed
the
unifyCompilerFilter
branch
from
52b3805 to
a35b063
Compare
SimeonEhrig
force-pushed
the
unifyCompilerFilter
branch
2 times, most recently
from
6c70272 to
20661f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 95.02% 95.69% +0.67%
==========================================
Files 11 10 -1
Lines 422 395 -27
Branches 102 99 -3
==========================================
- Hits 401 378 -23
+ Misses 11 10 -1
+ Partials 10 7 -3 ☔ View full report in Codecov by Sentry. |
SimeonEhrig
force-pushed
the
unifyCompilerFilter
branch
from
20661f0 to
ee930fb
Compare
- nvcc host compiler - same host and device compiler name and version - clang-cuda older than version 14
SimeonEhrig
force-pushed
the
unifyCompilerFilter
branch
from
ee930fb to
75e45e9
Compare
|
tested the refactoring with some extra rules [*] and it works.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to refactor compiler name and version filter because covertable requires another kind of filter rule description that it works.
This work is required to add backend based filter rules, which works together with the host and device compiler.