Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Adding filter software dependency rule #44

Closed
wants to merge 0 commits into from

Conversation

YuriiPerets
Copy link
Contributor

I'm not sure if the code working as it should. If I add a print(...) line, it seems like everything works fine, but the number of combinations in the terminal is always equal to 517

@SimeonEhrig
Copy link
Member

I'm not sure if the code working as it should. If I add a print(...) line, it seems like everything works fine, but the number of combinations in the terminal is always equal to 517

That's possible. Looks like the combination of GCC 6 + Ubuntu 20.04 could be placed in existing combinations. Therefore there was no need to add extra combinations that the pair exists. This means also, if you remove the pair no extra combination needs to be removed.

@SimeonEhrig
Copy link
Member

Please fix the tests, extend the get_expected_bashi_parameter_value_pairs() function to remove the pair GCC 6 + Ubuntu 20.04 and add some tests for the new functionality of the filter and the function get_expected_bashi_parameter_value_pairs().

Please ping also @sliwowitz , that he approves the CI. GitHub Actions has the security mechanism, that a maintainer needs to approve the CI each time, until the PR was merged the and the PR author become a contributor.

@YuriiPerets YuriiPerets marked this pull request as ready for review August 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants