Adding new filter rule(Ubuntu 20.04 does not support CUDA <10.2) #50

YuriiPerets · 2024-09-09T20:33:56Z

fix: #32

SimeonEhrig · 2024-09-13T05:59:24Z

I did a mistake in the issue description. CUDA 10.2 and older is not available in Ubuntu 20.04. You can check for < pkv.parse("11.0).

SimeonEhrig · 2024-09-13T06:54:43Z

src/bashi/filter_backend.py

@@ -143,6 +143,12 @@ def backend_filter(
                            return False
                        break

+        # Rule: b18
+        # related to rule
+        if row[ALPAKA_ACC_GPU_CUDA_ENABLE].version < pkv.parse("10.2"):


Suggested change

if row[ALPAKA_ACC_GPU_CUDA_ENABLE].version < pkv.parse("10.2"):

if row[ALPAKA_ACC_GPU_CUDA_ENABLE].version < pkv.parse("11.0"):

SimeonEhrig · 2024-09-13T07:03:57Z

src/bashi/filter_software_dependency.py

+                return False
+        for compiler in (HOST_COMPILER, DEVICE_COMPILER):
+            if compiler in row and row[compiler].name == CLANG_CUDA:
+                if row[compiler].version < CLANG_CUDA_MAX_CUDA_VERSION[3].clang_cuda:


Good point, that you check also for Clang-CUDA :-) Thanks correct and didn't thought about it.

Unfortunately, there is no guaranty that CLANG_CUDA_MAX_CUDA_VERSION keeps his ordering. Therefore you need to replace the direct access with a search function. Otherwise your code could silently break, if somebody modifies the CLANG_CUDA_MAX_CUDA_VERSION list. You need to implement the following function:

def get_max_supported_clang_cuda_ver(cuda_ver : str) -> str: """ returns the latest supported clang-cuda version for a given cuda version" # implement search algorithm # don't expect specific ordering of the list CLANG_CUDA_MAX_CUDA_VERSION # implement also tests

Implement the function in the version.py.

~~By the way, an entry of CLANG_CUDA_MAX_CUDA_VERSION stores only string. Therefore you need to parse the version. At the moment, you compare version objects with strings, which is always wrong.~~
The versions in ClangCudaSDKSupport are already parsed and stored as packaging.version.Version.

bashi/src/bashi/versions.py

Lines 51 to 64 in cc789bd

class ClangCudaSDKSupport(VersionSupportBase):

"""Contains a nvcc version and host compiler version. Does automatically parse the input strings

to package.version.Version.

Provides comparision operators for sorting.

"""

def __init__(self, clang_cuda_version: str, cuda_version: str):

VersionSupportBase.__init__(self, clang_cuda_version, cuda_version)

self.clang_cuda = self.version1

self.cuda = self.version2

def __str__(self) -> str:

return f"Clang-CUDA {str(self.clang_cuda)} + CUDA SDK {self.cuda}"

I suggest that the interface takes a string and the first step is parsing it to a version object. Makes the function call easier:

# expected string as argument (preferred version) get_max_supported_clang_cuda_ver("11.2") # expected version object as argument get_max_supported_clang_cuda_ver(pkv.parse("11.2")

# implementation for the preferred version def get_max_supported_clang_cuda_ver(cuda_ver : str) -> str: """ returns the latest supported clang-cuda version for a given cuda version" parsed_cuda_ver: pkv.Version = pkv.parse(cuda_ver) # implement search algorithm # don't expect specific ordering of the list CLANG_CUDA_MAX_CUDA_VERSION # implement also tests

SimeonEhrig · 2024-09-13T07:06:51Z

src/bashi/results.py

@@ -792,3 +793,31 @@ def _remove_unsupported_cmake_versions_for_clangcuda(
            value_name2=CMAKE,
            value_version2=">3.18",
        )
+
+
+def _remove_unsupported_cuda_versions_for_ubuntu(


This function needs also to remove unsupported device compiler nvcc + ubuntu 18.04 combinations and clang-cuda + ubuntu 18.04. I saw that the example.py misses the following combinations:

ParameterValuePair(first=ParameterValueSingle(parameter='device_compiler', parameterValue=ParameterValue(name='nvcc', version=<Version('10.0')>)), second=ParameterValueSingle(parameter='ubuntu', parameterValue=ParameterValue(name='ubuntu', version=<Version('20.4')>))) is missing in combination list ParameterValuePair(first=ParameterValueSingle(parameter='device_compiler', parameterValue=ParameterValue(name='nvcc', version=<Version('10.1')>)), second=ParameterValueSingle(parameter='ubuntu', parameterValue=ParameterValue(name='ubuntu', version=<Version('20.4')>))) is missing in combination list

But we cannot install CUDA 10.0 and 10.1 on Ubuntu 20.04

SimeonEhrig · 2024-09-13T07:11:29Z

I strongly recommend to fix the function _remove_unsupported_cuda_versions_for_ubuntu() first. You can do it with test cases and it is much easier than writing the filter rules. One time, if the function is working, running the example.py gives you also the correct hints, what is not correctly filtered and which filter rules needs to be fixed.

For example the jobs.yml which is generated by the example.py still the combination Ubuntu 18.04 + CUDA 10.1 if the host compiler is Clang-CUDA. We do not expect the combination. But _remove_unsupported_cuda_versions_for_ubuntu() is not correctly working and therefore the example.py will not tell you, that this unexpected combination was generated.

SimeonEhrig · 2024-10-01T20:02:00Z

src/bashi/results.py

+    parameter_value_pairs_ranges: List[ParameterValuePair],
+    removed_parameter_value_pairs: List[ParameterValuePair],
+):
+    removed_parameter_value_pairs(
+        parameter_value_pairs_ranges,
+        removed_parameter_value_pairs,


Instead calling the new function, you simply renamed the variable.

Suggested change

parameter_value_pairs_ranges: List[ParameterValuePair],

removed_parameter_value_pairs: List[ParameterValuePair],

):

removed_parameter_value_pairs(

parameter_value_pairs_ranges,

removed_parameter_value_pairs,

parameter_value_pairs: List[ParameterValuePair],

removed_parameter_value_pairs: List[ParameterValuePair],

):

remove_parameter_value_pairs_ranges(

parameter_value_pairs,

removed_parameter_value_pairs,

SimeonEhrig · 2024-10-03T16:36:19Z

src/bashi/results.py

+        value_name1=UBUNTU,
+        value_min_version1=20.04,
+        value_min_version1_inclusive=True,
+        value_max_version1=9999,


You can remove this argument. If you use the default argument for value_max_version1, it will delete all version bigger than 20.04, including 20,04.

SimeonEhrig · 2024-10-03T16:37:55Z

src/bashi/results.py

+        value_name1=UBUNTU,
+        value_min_version1=20.04,
+        value_min_version1_inclusive=True,
+        value_max_version1=9999,


Use the default argument, means the argument value_max_version1=9999,.

SimeonEhrig · 2024-10-03T16:38:01Z

src/bashi/results.py

+            value_name1=UBUNTU,
+            value_min_version1=20.04,
+            value_min_version1_inclusive=True,
+            value_max_version1=9999,


Use the default argument, means the argument value_max_version1=9999,.

SimeonEhrig · 2024-10-04T08:26:38Z

tests/test_results.py

+                ),
+            ]
+        )
+        expected_results = parse_expected_val_pairs(


Was some work to review this, but the expected results looks correct and the test in general. Remove the the value_max_version1=9999, and the validation site is ready. Therefore only the filter rules needs to be fixed.

SimeonEhrig · 2024-10-04T14:37:20Z

src/bashi/results.py

+        value_min_version2=OFF,
+        value_min_version2_inclusive=False,
+        value_max_version2=11,
+        value_max_version2_inclusive=True,


Suggested change

value_max_version2_inclusive=True,

value_max_version2_inclusive=False,

Needs to be exclusive, because otherwise you remove the pair Ubuntu 20.04 + CUDA 11.0.
Please also the pair to the tests. This corner case is not covered by your test casese. Only by the long running test.

SimeonEhrig · 2024-10-04T14:37:47Z