Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft:Adding new filter rule (all ROCm images are Ubuntu 20.04 based) #51

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Draft:Adding new filter rule (all ROCm images are Ubuntu 20.04 based) #51

merged 1 commit into from
Sep 17, 2024

Conversation

YuriiPerets
Copy link
Contributor

No description provided.

SimeonEhrig
SimeonEhrig reviewed Sep 10, 2024
View reviewed changes
src/bashi/filter_software_dependency.py Outdated Show resolved Hide resolved
src/bashi/filter_software_dependency.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (cc789bd) to head (87a2c90).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   94.87%   94.96%   +0.09%     
==========================================
  Files          10       10              
  Lines         663      675      +12     
  Branches      200      204       +4     
==========================================
+ Hits          629      641      +12     
  Misses         15       15              
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SimeonEhrig
SimeonEhrig reviewed Sep 12, 2024
View reviewed changes
src/bashi/filter_software_dependency.py Outdated Show resolved Hide resolved
src/bashi/filter_compiler.py Outdated Show resolved Hide resolved
src/bashi/filter_compiler.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
tests/test_hipcc_filter.py Show resolved Hide resolved
tests/test_hipcc_filter.py Show resolved Hide resolved
tests/test_filter_software_dependency.py Show resolved Hide resolved
src/bashi/results.py Show resolved Hide resolved
SimeonEhrig
SimeonEhrig reviewed Sep 16, 2024
View reviewed changes
src/bashi/filter_compiler.py Outdated Show resolved Hide resolved
src/bashi/filter_software_dependency.py Outdated Show resolved Hide resolved
src/bashi/filter_compiler.py Outdated Show resolved Hide resolved
SimeonEhrig
SimeonEhrig reviewed Sep 17, 2024
View reviewed changes
src/bashi/results.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
@SimeonEhrig
Copy link
Member

Please

  • resolve the last open conversations (scroll up the page)
  • squash the commits
  • change the PR from draft to "ready for review"

@SimeonEhrig SimeonEhrig marked this pull request as ready for review September 17, 2024 14:50
@SimeonEhrig SimeonEhrig merged commit f3a421a into alpaka-group:main Sep 17, 2024
8 checks passed
@SimeonEhrig SimeonEhrig mentioned this pull request Sep 17, 2024
Closed
@YuriiPerets YuriiPerets deleted the ROCmImgUbuntuBased branch September 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimeonEhrig SimeonEhrig SimeonEhrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuriiPerets @codecov-commenter @SimeonEhrig