Add new finder for authorised fuels (Defra) #2993
Conversation
lauraghiorghisor-tw
force-pushed
the
add-authorised-fuels-finder
branch
5 times, most recently
from
b125298 to
55a57d8
Compare
| "filter": { | ||
| "format": "authorised_fuel" | ||
| }, | ||
| "format_name": "Find authorised fuels for smoke control areas", |
There was a problem hiding this comment.
This line has gone away as of #3000
There was a problem hiding this comment.
I think the line stays. We're still generating it and including it in the schema. I tried it out in integration. 🤔
There was a problem hiding this comment.
Are you sure? I removed all references to it in the codebase and I've just tried submitting https://specialist-publisher.integration.publishing.service.gov.uk/admin/new and can't see format_name in the output...?
(It's possible someone had deployed an old branch to integration or something)
There was a problem hiding this comment.
Ah I thought you meant filter.format 😅
Yes, I will remove format_name.
| "related": [ | ||
| "https://www.gov.uk/smoke-control-area-rules", | ||
| "https://www.gov.uk/defra-approved-appliances" | ||
| ], |
There was a problem hiding this comment.
These need to be content IDs, I think - example
There was a problem hiding this comment.
Fixed. We need a link to the the other finder (appliances). Which makes me think we need to release that one first.
lauraghiorghisor-tw
force-pushed
the
add-authorised-fuels-finder
branch
from
55a57d8 to
7ea2412
Compare
lauraghiorghisor-tw
force-pushed
the
add-authorised-fuels-finder
branch
from
7ea2412 to
0f8c4aa
Compare
Few links missing, but ready to deploy to draft stack.
Trello