Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmic nhlt update #254

Closed
wants to merge 3 commits into from
Closed

Dmic nhlt update #254

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b05a6f
topology: nhlt: Intel: Add check for DMIC version
singalsu Feb 28, 2024
3bac294
topology: nhlt: Intel: Clear DMIC BFTH bits for version four
singalsu Feb 28, 2024
d77f87c
topology: nhlt: Intel: Improve all error prints
Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion topology/nhlt/intel/dmic/dmic-process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,10 @@ static int configure_registers(struct intel_dmic_params *dmic, struct dmic_calc_
}
}

if (dmic->dmic_prm[di].driver_version == 2 || dmic->dmic_prm[di].driver_version == 3) {
if (dmic->dmic_prm[di].driver_version >= 2) {
if (dmic->dmic_prm[di].driver_version >= 4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this saying that driver_version 4 and 5 are identical? I didn't see any other place where version 5 was checked, but it's allowed in the first patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now 4 and 5 are identical. If we need to enable new features of platform "5" there will be later more changes.

bfth = 0;

if (di == 0) {
ipm_helper2(dmic, source, &ipm);
val = OUTCONTROL0_TIE(0) |
Expand Down