Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Firebase dependencies #101

Merged
merged 4 commits into from
Oct 9, 2024
Merged

ci: Update Firebase dependencies #101

merged 4 commits into from
Oct 9, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Oct 8, 2024 •
edited
Loading

🙌 What I did

  • Update Firebase dependencies
  • Update minimum macOS version to 10.15
  • Update minimum iOS version to 15.5.0 from 14.0
  • Remove workaround for Xcode 15.0 in Podfile
  • Remove workaround CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES

✍️ What I didn't do

  • I can't build an example app that uses firebase_crashlytics on macOS.

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

@riscait riscait requested a review from a team as a code owner October 8, 2024 07:28
@riscait riscait requested review from naipaka and removed request for a team October 8, 2024 07:28
@riscait riscait marked this pull request as draft October 8, 2024 08:00
@riscait riscait marked this pull request as ready for review October 8, 2024 13:20
naipaka
naipaka approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for the update!

@riscait riscait merged commit cb34262 into main Oct 9, 2024
4 checks passed
@riscait riscait deleted the bump-firebase-dependencies branch October 9, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naipaka naipaka naipaka approved these changes

Assignees

@riscait riscait

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riscait @naipaka