fix(configurator): Fix configurator web unsupported error #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riscait
commented
Oct 22, 2024
| @@ -5,19 +5,19 @@ import 'dart:async'; | |||
| class Config<T> { | |||
| Config({ | |||
| required T value, | |||
| required StreamSubscription<void> subscription, | |||
| required StreamSubscription<void>? subscription, | |||
There was a problem hiding this comment.
I thought this.subscription would be fine, but I'm wondering if you're purposely assigning it to _subscription to keep it from being accessed externally.
Probably so, so it is left as is.
Suggested change
| required StreamSubscription<void>? subscription, | |
| this.subscription, |
There was a problem hiding this comment.
I was probably intending that!
riscait
commented
Oct 22, 2024
| @@ -1,18 +1,19 @@ | |||
| import 'dart:convert'; | |||
|
|
|||
| import 'package:firebase_remote_config/firebase_remote_config.dart'; | |||
| import 'package:meta/meta.dart'; | |||
| import 'package:flutter/foundation.dart'; | |||
There was a problem hiding this comment.
Added to use kIsWeb and made explicit the dependency on Flutter in pubspec as well!
riscait
commented
Oct 22, 2024
|
|
||
| import 'config.dart'; | ||
|
|
||
| typedef ValueChanged<T> = void Function(T value); | ||
| typedef _ValueChanged<T> = void Function(T value); |
There was a problem hiding this comment.
I made it private because it seems to be used only within this file.
riscait
commented
Oct 22, 2024
Comment on lines
+124
to
+129
| subscription: kIsWeb || onConfigUpdated == null | ||
| ? null | ||
| : filteredOnConfigUpdated(key).listen((event) async { | ||
| await activate(); | ||
| onConfigUpdated(getString(key)); | ||
| }), |
There was a problem hiding this comment.
Register subscriptions only when not on the web and onConfigUpdated is not null!
naipaka
approved these changes
Oct 22, 2024
| @@ -5,19 +5,19 @@ import 'dart:async'; | |||
| class Config<T> { | |||
| Config({ | |||
| required T value, | |||
| required StreamSubscription<void> subscription, | |||
| required StreamSubscription<void>? subscription, | |||
There was a problem hiding this comment.
I was probably intending that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
closes #14
🙌 What I did
✍️ What I didn't do
✅ Verification
Screenshots
Additional Information