build: Update lint package dependencies and integrate custom linting across packages #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naipaka
requested review from
riscait and
k-nkmr
and removed request for
boywithdv
naipaka
commented
Dec 2, 2024
| AppleAuthenticator(this._auth); | ||
|
|
||
| final FirebaseAuth _auth; | ||
|
|
||
| final authProvider = AppleAuthProvider(); | ||
| final _authProvider = AppleAuthProvider(); |
There was a problem hiding this comment.
I made it a private variable to match the other XxxAuthenticator, as it seemed to be used only internally!
k-nkmr
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
None
🙌 What I did
✍️ What I didn't do
✅ Verification
Screenshots
Additional Information