Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename to configurator #19

Merged
merged 1 commit into from
Nov 12, 2023
Merged

refactor: Rename to configurator #19

merged 1 commit into from
Nov 12, 2023

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Nov 12, 2023

🙌 What I did

  • Rename to configurator
    • fluttefire_remote_parameter_fetcher -> flutterfire_configurator
    • RemoteParameterFetcher -> Configurator
    • RemoteParameter -> Config
    • flutterfireremoteparameterfetcher -> flutterfireconfigurator

✍️ What I didn't do

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

Dependent on #18

@github-actions github-actions bot added documentation Improvements or additions to documentation test labels Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e44f4d1) 54.40% compared to head (96a1333) 54.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          10       10           
  Lines         261      261           
=======================================
  Hits          142      142           
  Misses        119      119           
Files Coverage Δ
...kages/flutterfire_configurator/lib/src/config.dart 100.00% <100.00%> (ø)
...flutterfire_configurator/lib/src/configurator.dart 90.78% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naipaka naipaka marked this pull request as ready for review November 12, 2023 05:52
@naipaka naipaka requested a review from riscait as a code owner November 12, 2023 05:52
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the rename!

Base automatically changed from refactor-flutterfire-remote-parameter-fetcher to main November 12, 2023 06:39
@naipaka naipaka force-pushed the rename-to-configurator branch from 30d881f to 96a1333 Compare November 12, 2023 06:44
@naipaka naipaka merged commit 4b15308 into main Nov 12, 2023
6 checks passed
@naipaka naipaka deleted the rename-to-configurator branch November 12, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants