[AltServer] Fixes potential race condition crash when managing connec…

…tions
altstoreio · Sep 14, 2022 · e80a49e · e80a49e
1 parent 4282474
commit e80a49e
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/Shared/Connections/ConnectionManager.swift b/Shared/Connections/ConnectionManager.swift
@@ -41,6 +41,7 @@ public class ConnectionManager<RequestHandlerType: RequestHandler>
     public var isStarted = false
 
     private var connections = [Connection]()
+    private let connectionsLock = NSLock()
 
     public init(requestHandler: RequestHandlerType, connectionHandlers: [ConnectionHandler])
     {
@@ -88,6 +89,9 @@ private extension ConnectionManager
 {
     func prepare(_ connection: Connection)
     {
+        self.connectionsLock.lock()
+        defer { self.connectionsLock.unlock() }
+
         guard !self.connections.contains(where: { $0 === connection }) else { return }
         self.connections.append(connection)
 
@@ -96,6 +100,9 @@ private extension ConnectionManager
 
     func disconnect(_ connection: Connection)
     {
+        self.connectionsLock.lock()
+        defer { self.connectionsLock.unlock() }
+
         guard let index = self.connections.firstIndex(where: { $0 === connection }) else { return }
         self.connections.remove(at: index)
     }