fix: next themes hydration errors #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@InfVlad is attempting to deploy a commit to the Alvaro Pea's projects Team on Vercel. A member of the Team first needs to authorize it. |
alvropena
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@InfVlad Thank you. We didn't notice this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #134 , resolves #135, resolves #136
Fixed hydration errors:
-Logo component was wrapped in Link component, then wrapped again in Link when used in landing header, causing hydration error element inside element
-The site logo was displaying the Logo while in Dark Theme, now shows as default the white logo, and chages to dark logo if needed
-The theme toggle now renders a placeholder first, then renders the correct icon and works even when the user doesn't have any saved theme in localstorage
Limitations:
-If the user is using light theme and reloads the page, for a few miliseconds while its loading the displayed logo is gonna be the white then change to the dark one.
-Next Themes provider configuration isn't working as expected, when the site is loaded in incognito mode theme is 'system' even when enableSystem = false and defaultTheme = 'dark' or 'light' (default). Related Next Themes Issue:
pacocoursey/next-themes#308