removed test for function with df

am-tropin · Nov 17, 2023 · 176916e · 176916e
1 parent 0acf4a0
commit 176916e
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 17 deletions.
diff --git a/app/tests/.ipynb_checkpoints/test_function_store-checkpoint.ipynb b/app/tests/.ipynb_checkpoints/test_function_store-checkpoint.ipynb
@@ -86,16 +86,32 @@
     "# https://github.com/shawnbrown/datatest/blob/bf136eab23c2b6ea36c201e1446fca9243c3fba6/docs/intro/automated-testing.rst#L139\n"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "85718085",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "# HOW TO VALIDATE DF\n",
+    "# examples:\n",
+    "\n",
+    "# https://github.com/fpdcc/fpcc_data_dashboard/blob/575e10a72a85617bd214906822271aa65ecced04/tests/tests.py\n",
+    "# https://github.com/DSuryavamshi/jenkins-test/blob/3e697c9f202a57b64b590430b3f5310d150074b7/test_processed_movies_csv.py#L15\n",
+    "\n",
+    "\n"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
    "id": "be80bbf2",
    "metadata": {},
    "outputs": [],
    "source": [
-    "def test_1_check_city_district_radius_floor_rooms():\n",
-    "#     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
-    "    assert check_city_district_radius_floor_rooms(grab_test_file, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
+    "# def test_1_check_city_district_radius_floor_rooms():\n",
+    "# #     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
+    "#     assert check_city_district_radius_floor_rooms(grab_test_file, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
     "    \n",
     "    \n",
     "#     assert check_city_district_radius_floor_rooms(\"Warszawa\", \"Śródmieście\", 2, 3, 2)"
@@ -192,7 +208,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "6f68e744",
+   "id": "c191829f",
    "metadata": {},
    "outputs": [],
    "source": [
@@ -206,23 +222,23 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "89d67440",
+   "id": "e186a1b5",
    "metadata": {},
    "outputs": [],
    "source": []
   },
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "86521164",
+   "id": "0da8eee0",
    "metadata": {},
    "outputs": [],
    "source": []
   },
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "97872ace",
+   "id": "b0f7385b",
    "metadata": {},
    "outputs": [],
    "source": []

diff --git a/app/tests/test_function_store.ipynb b/app/tests/test_function_store.ipynb
@@ -86,16 +86,32 @@
     "# https://github.com/shawnbrown/datatest/blob/bf136eab23c2b6ea36c201e1446fca9243c3fba6/docs/intro/automated-testing.rst#L139\n"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "85718085",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "# HOW TO VALIDATE DF\n",
+    "# examples:\n",
+    "\n",
+    "# https://github.com/fpdcc/fpcc_data_dashboard/blob/575e10a72a85617bd214906822271aa65ecced04/tests/tests.py\n",
+    "# https://github.com/DSuryavamshi/jenkins-test/blob/3e697c9f202a57b64b590430b3f5310d150074b7/test_processed_movies_csv.py#L15\n",
+    "\n",
+    "\n"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
    "id": "be80bbf2",
    "metadata": {},
    "outputs": [],
    "source": [
-    "def test_1_check_city_district_radius_floor_rooms():\n",
-    "#     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
-    "    assert check_city_district_radius_floor_rooms(grab_test_file, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
+    "# def test_1_check_city_district_radius_floor_rooms():\n",
+    "# #     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
+    "#     assert check_city_district_radius_floor_rooms(grab_test_file, \"Kraków\", \"Śródmieście\", 2, 3, 2) is False\n",
     "    \n",
     "    \n",
     "#     assert check_city_district_radius_floor_rooms(\"Warszawa\", \"Śródmieście\", 2, 3, 2)"
@@ -192,7 +208,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "6f68e744",
+   "id": "c191829f",
    "metadata": {},
    "outputs": [],
    "source": [
@@ -206,23 +222,23 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "89d67440",
+   "id": "e186a1b5",
    "metadata": {},
    "outputs": [],
    "source": []
   },
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "86521164",
+   "id": "0da8eee0",
    "metadata": {},
    "outputs": [],
    "source": []
   },
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "97872ace",
+   "id": "b0f7385b",
    "metadata": {},
    "outputs": [],
    "source": []

diff --git a/app/tests/test_function_store.py b/app/tests/test_function_store.py
@@ -74,9 +74,21 @@ def test_column_names(grab_test_file):
 # In[ ]:
 
 
-def test_1_check_city_district_radius_floor_rooms():
-#     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, "Kraków", "Śródmieście", 2, 3, 2) is False
-    assert check_city_district_radius_floor_rooms(grab_test_file, "Kraków", "Śródmieście", 2, 3, 2) is False
+# HOW TO VALIDATE DF
+# examples:
+
+# https://github.com/fpdcc/fpcc_data_dashboard/blob/575e10a72a85617bd214906822271aa65ecced04/tests/tests.py
+# https://github.com/DSuryavamshi/jenkins-test/blob/3e697c9f202a57b64b590430b3f5310d150074b7/test_processed_movies_csv.py#L15
+
+
+
+
+# In[ ]:
+
+
+# def test_1_check_city_district_radius_floor_rooms():
+# #     assert check_city_district_radius_floor_rooms(TEST_APARTMENTS_DF, "Kraków", "Śródmieście", 2, 3, 2) is False
+#     assert check_city_district_radius_floor_rooms(grab_test_file, "Kraków", "Śródmieście", 2, 3, 2) is False
 
 
 #     assert check_city_district_radius_floor_rooms("Warszawa", "Śródmieście", 2, 3, 2)