Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of PKs to split out parseParameterList, make SetEvaluator() call EnsureEvaluators() #40

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

ecoon
Copy link
Contributor

@ecoon ecoon commented Aug 30, 2024

This PR is joint with amanzi/ats#270 and amanzi/amanzi#860.

Those PRs:

  1. make it so that we don't need "source term is differentiable", as the PK can just ask the evaluator. (see should the sub-dag be valid as soon as an evaluator is required? ats#167)
  2. This also potentially changes the order of which evaluators are created; as such some evaluators which create multiple variables (e.g. molar_density_liquid and mass_density_liquid), now the other variable is required first. There is currently no good way of dealing with this in Amanzi-ATS, so we're stuck changing the name in the input file. This is going to annoy people, but maybe we can just script the duplication of the list under both names in the input converter?

@ecoon ecoon merged commit f704f0c into master Aug 30, 2024
@ecoon ecoon deleted the ecoon/ats_167 branch August 30, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant