0.5.0 #1
Closed
0.5.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue came up on the Max17261, where the addressing is non-contiguous. In v0.4.0, accessing the registers by address caused a buffer overflow because the address was larger than the indexable register map. The solution is an array of addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.5.0 Changes
The
peripheral!macro now requires an additional argument, the type of the address - This is used to create a map of addresses vs. index. The arose with the Max17261 where the address space is non-liner, in this case the addressing skipped from 0x4F to 0xB0 and again from 0xBF to 0xD0. Theperipheral!macro stores the registers contiguously in memory as they are listed, so an additional map of index vs. address was needed to correctly access the non-linearly addressed registers.Replaced
direct_updatewithdirect_update_by_address- This utilized the new index / address array to find the correct register by address.Added
find_index_by_addresswhich attempts to find index based on the address.Updated examples and tests