0.5.1 #2
Merged
0.5.1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue came up on the Max17261, where the addressing is non-contiguous. In v0.4.0, accessing the registers by address caused a buffer overflow because the address was larger than the indexable register map. The solution is an array of addresses.
The bitfield and bitrange macros getters and setters are generated as traits. To use the getter / setter, the trait needs to be imported. A bitfield named chg_en in the Status register can now be imported as use (namespace)::Status_chg_en to keep things more consistant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2's compliment, better trait naming to prevent collisions, added address index for non-linear peripheral address spaces.