Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Nushi character preliminary implementation with ricochet movement #72

Merged
merged 4 commits into from
Jul 6, 2019
Merged

Nushi character preliminary implementation with ricochet movement #72

merged 4 commits into from
Jul 6, 2019

Conversation

orhanbalci
Copy link
Contributor

This is a preliminary implementation for nushi character described in #61. New behavior ricochet is added. Characters with ricochet behavior bounces off the world bounds. Initialization of singleton Nushi character is done in game initialization. Maybe this can be moved into a SingletonSpawner system.

-Characters with ricochet behavior bounces off the world bounds
@erlend-sh
Copy link
Member

erlend-sh commented May 24, 2019

Thanks for the PR! We’re on the verge of shipping our v0.1.0 MVP release so it might be a few days until we can merge this in.

Was there anything about implementing a new creature that was particularly painful?

@orhanbalci
Copy link
Contributor Author

Actually this was the first time I worked with ECS based framework. It enables developer to only focus on the real behavior your want. The only think that I missed was to insert new component into CreaturePrefabData struct in order to be able to use it in prefab definition (.ron) files. This was due to my lack of knowledge. I needed to head back to documentation.

Copy link
Member

@khskarl khskarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! And thank you for the contribution 🎉.

Sidenote

We finally have the most important creature, the bouncing DVD logo: https://bouncingdvdlogo.com/

src/states/main_game.rs Outdated Show resolved Hide resolved
src/states/main_game.rs Outdated Show resolved Hide resolved
@khskarl khskarl merged commit 7c1f379 into amethyst:master Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants