Penguin/master - Lindsey & Alice #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding their own products to the cart
Product model/ar
Lr/user model
Added a continue shopping link to cart page that returns to root_path
Changed radio buttons to regular buttons
Refactor orders controller/ar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lindseyreno & I incorporated PenguinShipper into CosMade, this bEtsy app. We added address attributes to the User (merchant) model and weight/dimension attributes to the Product model to facilitate this.
CosMade lives here: https://intense-garden-9830.herokuapp.com/
PenguinShipper lives here (but there's nothing to see): https://whispering-shore-8365.herokuapp.com/
There were 14 broken rspec tests when we inherited bEtsy. We commented some out (in the product model), and left the rest.
We added a shipping stage in the order checkout flow between entering payment details and finalizing the order. Here, the buyer was given shipping options (from an API call to PenguinShipper), had to choose an option before they could continue, and was shown the shipping price on the confirmation page. We saved the selected shipping service, and cost in the order model, and sent another API request back to PenguinShipper to log our choice.
The only refactoring we did on the original bEtsy code was to incorporate FactoryGirl into some of the specs. We could still refactor some of our additions. The finalize method in the OrdersController is doing too much work at present.
🐧