Skip to content

Commit

Permalink
📝 Writing docs.
Browse files Browse the repository at this point in the history
Signed-off-by: mgorsk1 <[email protected]>
  • Loading branch information
mgorsk1 committed Mar 18, 2021
1 parent 38f30bf commit 347aacc
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rfcs/028-simplify-config-customization.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,11 @@ print(t.__dict__)

## Alternatives

- Make every config option use os.getenv with default value
- pros: config will stay more flexible in terms of defining more complex variables (functions, dicts)
- cons: there is no centralization of parsing logic

- Keep current approach forcing users to provide config files, mounting them and keeping in PATH.
- Make every config option use os.getenv with default value (in my opinon it's worse since there is no centralization of parsing logic)

## Prior art

Expand Down

0 comments on commit 347aacc

Please sign in to comment.