Skip to content

Commit

Permalink
🐛 Fixing a bug.
Browse files Browse the repository at this point in the history
Signed-off-by: mgorsk1 <[email protected]>
  • Loading branch information
mgorsk1 committed Mar 18, 2021
1 parent 931342e commit 9542cc8
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions rfcs/028-simplify-config-customization.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,7 @@ N/A
## Reference-level Explanation (aka Technical Details)

1. Add `get_config_class(component: string, base_class: Config) -> Config` method to amundsen common
2. Use `get_config_class` in each service, for example:

```python
from amundsen.common.config import get_config_class

_config_module_class = \
os.getenv('METADATA_SVC_CONFIG_MODULE_CLASS') or _config_module_class

config_module_class = get_config_class('metadata', _config_module_class)
```
2. Use `get_config_class` in each service to render final config

Pseudocode:

Expand Down Expand Up @@ -119,7 +110,7 @@ def get_config_class(component, base_class):
return ConfigClass
```

##### Amundsen Metadata
##### Usage

```python
import os
Expand Down

0 comments on commit 9542cc8

Please sign in to comment.