fix: sizeRem regression in v4.3.1 to transform px to rem #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This was referenced Jan 21, 2025
dbanksdesign
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes #1435
Description of changes:
Earlier PR #1432 which was released as v4.3.1 introduced the regression.
Due to adding the ^ at the start of the regex, it no longer matched e.g. "5px" since the first character doesn't match a unit character. Unfortunately we didn't have a test for this before.
Pkg lock changes is from doing
npm audit fixsince we had some vulnerable dev dependenciesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.