Fix Handling of Optional Zod Fields with NestJS Swagger #194
+65
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Anatine Team,
I've encountered an issue where optional object fields defined with Zod are incorrectly treated as required by NestJS Swagger. Upon investigation, I discovered that NestJS Swagger defaults to marking fields as required unless explicitly stated otherwise. This behavior leads to a discrepancy when integrating Zod schemas, as fields intended to be optional are handled as required.
Issue Example:
Consider the following schema, where both pagination and filter are intended as optional fields:
In this scenario, NestJS Swagger incorrectly applies required: true to all fields, ignoring the optional designation provided by Zod.
Proposed Solution:
To address this issue, we must explicitly set required: false for fields where schemaObject.required is undefined. This ensures that our intent of marking fields as optional is accurately reflected in the generated Swagger documentation.
I believe this adjustment will enhance the integration compatibility between Zod and NestJS Swagger, ensuring that optional fields are correctly recognized and treated as such.
I look forward to your feedback on this proposed fix.