Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tüm olaylar socket objesine taşındı #88

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

saracalihan
Copy link
Member

Watchingroom sayfasında bulunan tüm olaylar en az iş yükünü ve okunaklığı oluşturacak şekilde ilgili komponentlere taşındı.

Farkli yerlerden tek bir client ile socket.on ve socket.emit islemlerini
yapabilmeye olanak saglayan obje eklendi. connect fonksiyonu react
component'i disinda tanimlanmalidir.

.env dosyasinda DEBUG_WEBSOCKET alani "true" ise veya NODE_ENV
"development" ise log yapar
@saracalihan saracalihan added the ready for review The issue is solved and waiting for review label Feb 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The issue is solved and waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant