Refactoring structure of the launcher app menu #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability use B as back button in the menu. Every menu item has a submenu or callback func. Also added update method to the menu to update the menu items (postfix in WiFi item: ON/OFF).
drronnie85
changed the title
drronnie85
changed the title
This reverts commit 7c0800a.
|
Упс. Випадково залив кривий statusbar.cpp. |
frostmorn
reviewed
Dec 27, 2024
firmware/keira/src/apps/launcher.cpp
Outdated
| AppManager::getInstance()->runApp(list[index].construct()); | ||
| menu_icon_t* icon = list[i].icon; | ||
| if (icon == NULL) { | ||
| icon = list[i].submenu.empty() ? &app_img : &app_group_img; |
There was a problem hiding this comment.
вот, через це в налаштуваннях і таблиці розділів тепер є іконки яких не було :)
There was a problem hiding this comment.
Лол) Було відчуття що щось не так) Але не зрозумів, що саме.
|
а загалом норм |
frostmorn
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155
Ability use B as back button in the menu.
Every menu item has a submenu or callback func.
Also added update method to the menu to update the menu items (postfix in WiFi item: ON/OFF).