-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add github workflow actions (test, publish)
- Loading branch information
1 parent
fe0078b
commit 84d0eae
Showing
11 changed files
with
154 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Publish package | ||
on: | ||
release: | ||
types: [created] | ||
|
||
jobs: | ||
deploy: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: '3.10' | ||
architecture: 'x64' | ||
|
||
- name: Install dependencies and package | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install -r requirements.txt | ||
- name: Build source and binary distribution package | ||
run: | | ||
python setup.py sdist bdist_wheel | ||
env: | ||
PACKAGE_VERSION: ${{ github.ref }} | ||
|
||
- name: Check distribution package | ||
run: | | ||
twine check dist/* | ||
- name: Publish distribution package | ||
run: | | ||
twine upload dist/* | ||
env: | ||
TWINE_REPOSITORY: ${{ secrets.PYPI_REPOSITORY }} | ||
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
TWINE_NON_INTERACTIVE: yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
name: Run linter and tests | ||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: | ||
- '3.8' | ||
- '3.9' | ||
- '3.10' | ||
- '3.11' | ||
django-version: | ||
- '3.2' | ||
- '4.1' | ||
- '4.2' | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies and package | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install -r requirements.txt | ||
pip install django~=${{ matrix.django-version }}.0 | ||
- name: Run lint and code review with isort and black | ||
run: | | ||
pre-commit run --all-files | ||
- name: Run tests with coverage | ||
run: | | ||
# prepare Django project: link all necessary data from the test project into the root directory | ||
# Hint: Simply changing the directory does not work (leads to missing files in coverage report) | ||
ln -s ./tests/core core | ||
ln -s ./tests/testapp testapp | ||
ln -s ./tests/manage.py manage.py | ||
# run tests with coverage | ||
coverage run \ | ||
--source='./django_generic_contact' \ | ||
manage.py test | ||
coverage xml | ||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ | |
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("django_generic_contact", "0001_initial"), | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
from django.core.exceptions import ValidationError | ||
from django.test import TestCase | ||
|
||
from django_generic_contact.models import Contact, GENERIC_CONTACT_DATA_SCHEMA | ||
from django_generic_contact.models import GENERIC_CONTACT_DATA_SCHEMA, Contact | ||
from django_generic_contact.validators import JSONSchemaValidator | ||
|
||
|
||
|
@@ -13,7 +13,7 @@ def test_successful_contact_creation(self): | |
data={ | ||
"email": "[email protected]", | ||
"phone": "123456", | ||
} | ||
}, | ||
) | ||
|
||
self.assertEqual(Contact.objects.count(), 1) | ||
|
@@ -22,25 +22,29 @@ def test_successful_contact_creation(self): | |
class TestJsonSchema(TestCase): | ||
def test_successful_jsonschema_validation(self): | ||
validator = JSONSchemaValidator(limit_value=GENERIC_CONTACT_DATA_SCHEMA) | ||
validator({ | ||
"email": "[email protected]", | ||
"not_validated_phone": "+431234567", | ||
}) | ||
validator( | ||
{ | ||
"email": "[email protected]", | ||
"not_validated_phone": "+431234567", | ||
} | ||
) | ||
|
||
def test_failed_jsonschema_validation_invalid_email(self): | ||
validator = JSONSchemaValidator(limit_value=GENERIC_CONTACT_DATA_SCHEMA) | ||
with self.assertRaises( | ||
ValidationError, | ||
msg="'invalid_email' is not a 'email'\n\n" | ||
"Failed validating 'format' in schema['properties']['email']:\n" | ||
" {'format': 'email', 'type': 'string'}\n\n" | ||
"On instance['email']:\n" | ||
" 'invalid_email'" | ||
ValidationError, | ||
msg="'invalid_email' is not a 'email'\n\n" | ||
"Failed validating 'format' in schema['properties']['email']:\n" | ||
" {'format': 'email', 'type': 'string'}\n\n" | ||
"On instance['email']:\n" | ||
" 'invalid_email'", | ||
): | ||
validator({ | ||
"email": "invalid_email", | ||
"not_validated_phone": "+431234567", | ||
}) | ||
validator( | ||
{ | ||
"email": "invalid_email", | ||
"not_validated_phone": "+431234567", | ||
} | ||
) | ||
|
||
def test_failed_jsonschema_validation_additional_fields(self): | ||
test_schema = { | ||
|
@@ -53,14 +57,16 @@ def test_failed_jsonschema_validation_additional_fields(self): | |
} | ||
validator = JSONSchemaValidator(limit_value=test_schema) | ||
with self.assertRaises( | ||
ValidationError, | ||
msg="'+431234567' is not of type 'integer'\n\n" | ||
"Failed validating 'type' in schema['properties']['phone']:\n" | ||
" {'type': 'integer'}\n\n" | ||
"On instance['phone']:\n" | ||
" '+431234567'" | ||
ValidationError, | ||
msg="'+431234567' is not of type 'integer'\n\n" | ||
"Failed validating 'type' in schema['properties']['phone']:\n" | ||
" {'type': 'integer'}\n\n" | ||
"On instance['phone']:\n" | ||
" '+431234567'", | ||
): | ||
validator({ | ||
"email": "[email protected]", | ||
"phone": "+431234567", | ||
}) | ||
validator( | ||
{ | ||
"email": "[email protected]", | ||
"phone": "+431234567", | ||
} | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters